davisp commented on a change in pull request #866: Fix incorrect index
selection when sort specified
URL: https://github.com/apache/couchdb/pull/866#discussion_r143808448
##########
File path: src/mango/src/mango_selector.erl
##########
@@ -398,6 +400,14 @@ negate({[{Field, Cond}]}) ->
{[{Field, negate(Cond)}]}.
+norm_deduplicate({[{Op, [H|T]}]}) ->
+ Arg = [H | [X || X <- norm_deduplicate(T), X /= H]],
Review comment:
This really hurts my brain to read. And not knowing what's supposed to call
it I can't figure out if its correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
