davisp commented on a change in pull request #883: Fix erlang time module
compatibility
URL: https://github.com/apache/couchdb/pull/883#discussion_r143804473
##########
File path: src/couch/src/couch_auth_cache.erl
##########
@@ -203,7 +203,8 @@ handle_call({fetch, UserName}, _From, State) ->
[] ->
couch_stats:increment_counter([couchdb, auth_cache_misses]),
Creds = get_user_props_from_db(UserName),
- State1 = add_cache_entry(UserName, Creds, erlang:now(), State),
+ ATime = couch_time_compat:unique_integer([monotonic, positive]),
Review comment:
Seems like this would be more useful as couch_util:unique_integer() that
gets left forever rather than replacing all of these with
erlang:unique_integer/1 in the future (we do this for a few different things
where we always set the same options if memory serves).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
