willholley commented on a change in pull request #866: Fix incorrect index
selection when sort specified
URL: https://github.com/apache/couchdb/pull/866#discussion_r143991549
##########
File path: src/mango/src/mango_selector.erl
##########
@@ -398,6 +400,14 @@ negate({[{Field, Cond}]}) ->
{[{Field, negate(Cond)}]}.
+norm_deduplicate({[{Op, [H|T]}]}) ->
Review comment:
It's a step in the selector normalization - (line 40 above). The intention
is to deduplicate predicates (particularly `"$exists": true`) but this isn't
necessary for correctness - it just makes the normalized selector cleaner.
Thinking about it again, I'll remove it here and will consider improving
selector normalization in a different PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
