davisp commented on a change in pull request #849: Fix external size bug when
seq btree exists
URL: https://github.com/apache/couchdb/pull/849#discussion_r148115197
##########
File path: src/couch_mrview/src/couch_mrview_util.erl
##########
@@ -796,24 +796,30 @@ changes_ekey_opts(_StartSeq, #mrargs{end_key=EKey,
end.
-reduced_external_size(Tree) ->
+reduced_external_size(btree, Tree) ->
Review comment:
Matching on the arg is a bit odd here. I'd make this two different functions
that you call directly in calculate_eternal_size/1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
