garrensmith commented on a change in pull request #1023: Add show/hide alert
badge on navbar items
URL: https://github.com/apache/couchdb-fauxton/pull/1023#discussion_r151971665
##########
File path: app/addons/fauxton/navigation/components/NavLink.js
##########
@@ -26,12 +26,17 @@ const NavLink = ({link, active, isMinimized}) => {
{'faux-navbar--narrow': isMinimized}
);
+ // const iconBadgeClass = link.badge ? : '';
return (
<a className={linkClass} href={link.href} target={link.target ? '_blank' :
null} data-bypass={link.target ? 'true' : null}>
<div data-nav-name={link.title} className="faux-navbar__itemarea">
{!!link.icon ?
- <i className={classNames(link.icon, 'fonticon
faux-navbar__icon')}></i> :
+ <i className={classNames(
Review comment:
I know it was like this before, but what do you think about moving the this
part out of the return and just rather have a variable we add here? I always
find having an `if statement` in the JSX to be really confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
