eiri opened a new pull request #1105: Remove warning on `couch_epi_codegen` compilation URL: https://github.com/apache/couchdb/pull/1105 ## Overview There are mouthful depreciation warning on epi compilation on none-ancient versions of erlang ``` Warning: erl_scan:token_info/2: removed in 19.0; use erl_scan:{category,column,line,location,symbol,text}/1 instead ``` The module `couch_epi_codegen` actually decides what scan token to use based on `function_exported`, but the warning is thrown anyway. The patch changes runtime choice between `erl_scan:token_info` and `erl_scan:line` to compilation conditional one based in rebar's `platform_define`. This is getting rid of compilation deprecation warning and also should speed up things a bit. ## Testing recommendations Basic recompile to confirm the warning is gone and `make eunit apps=couch_epi` to ensure that things are not broken. I've tested it on: - 17.5 - 18.3 - 19.3 - 20.2 ## Checklist - [x] Code is written and works correctly; - [x] Changes are covered by tests; - [ ] Documentation reflects the changes;
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
