eiri commented on issue #1122: should_create_delete_database_continuously (100 
times) fails on Jenkins CI
URL: https://github.com/apache/couchdb/issues/1122#issuecomment-359524690
 
 
   No, the test actually been calling `couch_db:delete/2` inside `cycle`, 
inside `loop`, inside `_assert,` inside `timeout`, inside a list comprehension 
- [right 
here](https://github.com/apache/couchdb/blob/e81c54e32d2a165dc762ad4217b753da723dc1fa/src/couch/test/couch_db_tests.erl#L127).
 It just hard to see because the thing been rather convoluted. 
   
   The semantics didn't changed, we are still calling same `couch_db:create/2`, 
`couch_db:close/1` (inside `create_db` helper) and then `couch_server:delete/2` 
inside `delete_db` helper repeatedly. 
   
   What changed is wrapping `?_test` that ensure that we are not ignoring 
failures in preparation stages, i.e. that initial db creation or in between 
asserts, I suppose that's how it was passing before. I'll look into this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to