nickva commented on a change in pull request #1129: Elixir suite davisp URL: https://github.com/apache/couchdb/pull/1129#discussion_r164227330
########## File path: test/elixir/lib/couch.ex ########## @@ -72,4 +131,35 @@ defmodule Couch do %HTTPotion.ErrorResponse{ message: error_to_string(reason)} end end + + # Anther HACK: Until we can get process_request_headers/2 merged + # upstream. + @spec process_arguments(atom, String.t, [{atom(), any()}]) :: %{} + defp process_arguments(method, url, options) do + options = process_options(options) + + body = Keyword.get(options, :body, "") + headers = Keyword.merge Application.get_env(:httpotion, :default_headers, []), Keyword.get(options, :headers, []) Review comment: Ah alright. Makes sense. Let's keep it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services