rnewson commented on a change in pull request #1127: Fix for issue #603 - Error
500 when creating a db below quorum
URL: https://github.com/apache/couchdb/pull/1127#discussion_r164447431
##########
File path: src/fabric/src/fabric_db_create.erl
##########
@@ -146,9 +146,9 @@ maybe_stop(W, Counters) ->
{ok, {W, Counters}};
false ->
case lists:sum([1 || {_, ok} <- Counters]) of
- W ->
+ NumOk when NumOk >= (W div 2 +1) ->
{stop, ok};
- NumOk when NumOk >= (W div 2 + 1) ->
+ NumOk when NumOk > 0 ->
Review comment:
this is the right change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services