pierrekilly commented on a change in pull request #1160: Add support for Bcrypt
password hashing
URL: https://github.com/apache/couchdb/pull/1160#discussion_r167857812
##########
File path: src/couch/src/couch_passwords.erl
##########
@@ -51,7 +51,10 @@ hash_admin_password("pbkdf2", ClearPassword) ->
Salt ,list_to_integer(Iterations)),
?l2b("-pbkdf2-" ++ ?b2l(DerivedKey) ++ ","
++ ?b2l(Salt) ++ ","
- ++ Iterations).
+ ++ Iterations);
+hash_admin_password("bcrypt", ClearPassword) ->
+ Iterations = list_to_integer(config:get("couch_httpd_auth", "iterations",
"12")),
Review comment:
Ho, I guess I should rename the parameter into `logRounds` as the real
amount if iterations performed is actually 2^logRounds.
I'll change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
