rnewson commented on a change in pull request #1176: Implement pluggable 
authentication and session support for replicator
URL: https://github.com/apache/couchdb/pull/1176#discussion_r170086079

 File path: src/couch_replicator/src/couch_replicator_auth.erl
 @@ -0,0 +1,100 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you may not
+% use this file except in compliance with the License. You may obtain a copy of
+% the License at
+%   http://www.apache.org/licenses/LICENSE-2.0
+% Unless required by applicable law or agreed to in writing, software
+% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+% License for the specific language governing permissions and limitations under
+% the License.
+    initialize/1,
+    update_headers/2,
+    handle_response/4,
+    cleanup/1
+-type headers() :: [{string(), string()}].
+-type code() :: non_neg_integer().
+    "couch_replicator_auth_session,couch_replicator_auth_basic").
+% Behavior API
+-callback initialize(#httpdb{}) -> {ok, #httpdb{}, term()} | ignore.
+-callback update_headers(term(), headers()) -> {headers(), term()}.
 Review comment:
   this makes the (reasonable) assumption that all auth systems work via 
headers, but it isn't an ideal abstraction. The intention behind allowing a 
callback to update headers is to apply the authentication whatevers, so perhaps 
that would be a better shape?

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to