janl commented on issue #1160: Add support for Bcrypt password hashing
URL: https://github.com/apache/couchdb/pull/1160#issuecomment-368027284
 
 
   @pierrekilly nice work overall, and thanks again for the contribution. This 
is nearly ready to go, but it?d be great to get test coverage up a little bit. 
Namely, it?d be great to have a test that proves that:
   
   - [ ] after setting the password scheme to `bcrypt`:
     - [ ] that creation of users works
     - [ ] that users can authenticate
     - [ ] that the password scheme in the users doc is indeed `bcrypt`
   - [ ] for admin users in the couchdb config
     - [ ] that creation of admins works
     - [ ] that admins can authenticate
     - [ ] that the password scheme in the configuration is indeed `bcrypt`
   -[ ] that users with passwords hashed by different schemes can still log in, 
with the tasing scheme changed
     - [ ] create new user (has pbkdf2 hash)
     - [ ] change hash

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to