rnewson commented on a change in pull request #1176: Implement pluggable 
authentication and session support for replicator
URL: https://github.com/apache/couchdb/pull/1176#discussion_r170285480

 File path: src/couch_replicator/src/couch_replicator_auth_basic.erl
 @@ -0,0 +1,52 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you may not
+% use this file except in compliance with the License. You may obtain a copy of
+% the License at
+%   http://www.apache.org/licenses/LICENSE-2.0
+% Unless required by applicable law or agreed to in writing, software
+% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+% License for the specific language governing permissions and limitations under
+% the License.
 Review comment:
   the `http://user:pass@host/db` form is never what's sent in an http request, 
though. the user:pass part has to be converted to `Authentication: Basic 
<goop>`. That translation is happening elsewhere (in ibrowse), leaving this 
module empty. It's just a bit odd to call this module 'basic' as if it does 
basic auth, when in fact it does nothing (and basic auth happens independently).

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to