nickva commented on issue #1176: Implement pluggable authentication and session support for replicator URL: https://github.com/apache/couchdb/pull/1176#issuecomment-368404943 I made two updates to the PR over the weekend: 1. Added more unit tests covering various cookie update states in `_auth_session` plugin: https://github.com/cloudant/couchdb/blob/921609e9ce3b3e535561816b3e435b039ad731df/src/couch_replicator/src/couch_replicator_auth_session.erl#L554-L648 2. Realized when we POST-ed to `_session` with content type `application/x-www-form-urlencoded` we didn't actually urlencode username and password param values. So enabled that: https://github.com/cloudant/couchdb/blob/921609e9ce3b3e535561816b3e435b039ad731df/src/couch_replicator/src/couch_replicator_auth_session.erl#L554-L648
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
