davisp commented on issue #1164: Fix: Proper error handling for file:open() 
call in couch_file.erl
URL: https://github.com/apache/couchdb/pull/1164#issuecomment-370807541
 
 
   @rnewson yes and no. The issue is where we want that badmatch to happen and 
with what as the badmatch. For the init section this is a good change as it 
matches the initial open. What's being added is the handling when the second of 
two fails to behave the same as the first. This is fine as we already handle 
the error. And it cleans up logs a bit in that the emfile error happens in the 
process doing the open rather than a EXIT/DOWN message when the couch_file pid 
dies on a badmatch.
   
   As for the init process this just reuses the existing logic which seems 
cleaner than going back and rewriting it to use proc_lib properly.
   
   +1 after style issues are addressed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to