flimzy commented on a change in pull request #219: Fix _cluster_setup api | 
couchdb node name changes | verify cluster setup  

 File path: src/cluster/setup.rst
 @@ -211,12 +214,11 @@ requires all other nodes to be able to see it and vice 
 Set up will not work with unavailable nodes.
 The notion of "setup coordination node" will be gone once the setup is 
 From then on, the cluster will no longer have a "setup coordination node".
-To add a node run these two commands:
+To add a node run these commands for each node you want to add:
 .. code-block:: bash
     curl -X POST -H "Content-Type: application/json" 
http://admin:password@ -d '{"action": 
"enable_cluster", "bind_address":"", "username": "admin", 
"password":"password", "port": 15984, "node_count": "3", "remote_node": 
"<remote-node-ip>", "remote_current_user": "<remote-node-username>", 
"remote_current_password": "<remote-node-password>" }'
-    curl -X POST -H "Content-Type: application/json" 
http://admin:password@ -d '{"action": "add_node", 
"host":"<remote-node-ip>", "port": "<remote-node-port>", "username": "admin", 
+    curl -X POST -H "Content-Type: application/json" 
http://admin:password@ -d '{"action": "add_node", 
"host":"<remote-node-ip>", "port": <remote-node-port>, "username": "admin", 
 Review comment:
   Are you sure the port doesn't need to be a string? AFAIK, all config values 
are strings. Not to mention, a port can (probably) be non-numeric, i.e. `http` 
or `https`, etc.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to