eiri commented on a change in pull request #1187: [WIP] Couchdb 3326 clustered purge URL: https://github.com/apache/couchdb/pull/1187#discussion_r173861185
########## File path: src/couch/src/couch_bt_engine_compactor.erl ########## @@ -58,6 +58,7 @@ start(#st{} = St, DbName, Options, Parent) -> NewSt3 = sort_meta_data(NewSt2), NewSt4 = commit_compaction_data(NewSt3), NewSt5 = copy_meta_data(NewSt4), + couch_db_plugin:before_copy_purge_info(DbName), Review comment: @nickva I think the idea was that this bit needed only during migration from pre-purge to post-purge and with plugin it'll be easier to take this out later. Sure it could be just a function and we'll remove code a release or two after, but presumably you can also do some interesting things with `before_compaction` hook, more intelligent compaction daemon with feedback, for example. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services