jiangphcn commented on issue #1187: [WIP] Couchdb 3326 clustered purge URL: https://github.com/apache/couchdb/pull/1187#issuecomment-372517972 Thanks @davisp @eiri @nickva. >Lastly, the plugin references in couch_index should go away and that should be written in couch_mrview as that's the indexer with the logic. Passing through a couch_index module is superfluous. Also I'd pull that logic out into its own couch_mrview_plugin module or similar rather than overloading the maybe_create_local_purge_doc (yes its named similar but the logic for its use is completely different). Although we should very much keep the logic as written so that we're not required to open the underlyinng index which could very well overload deployments that have huge numbers of indexes. Regarding above comments, I understand that it would be better to put it to couch_mrview. However, it looks that couch_mrview is one *plugin* to couch_index. The control logic is at couch_index. I can pull logic from couch_index to couch_mrview and implement couch_mrview_plugin and couch_mrview_epi. But we still need to register couch_mrview_epi in some place, like https://github.com/apache/couchdb/blob/master/src/couch_index/src/couch_index_sup.erl#L24 This looks that it can't be done without bothering couch_index. so this is why I put new epi function to couch_index and add call to couch_mrview to write local purge doc.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
