nickva commented on a change in pull request #1277: In _scheduler/docs fix
`crashing` state showing as `pending` sometimes
URL: https://github.com/apache/couchdb/pull/1277#discussion_r180857972
##########
File path: src/couch_replicator/src/couch_replicator_scheduler.erl
##########
@@ -138,11 +138,15 @@ job_summary(JobId, HealthThreshold) ->
ErrorCount = consecutive_crashes(History, HealthThreshold),
{State, Info} = case {Pid, ErrorCount} of
{undefined, 0} ->
- {pending, null};
+ case History of
Review comment:
The difference is that when it is 0 we only show an error if the last event
is an error, otherwise it is pending. So it is really a `pending` case mostly
so I left it that way to make it easy to think about the 3 states as separate
`case` clauses: pending, crashing and running.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
