nickva commented on a change in pull request #2: Fix tests to run with Triq
URL: https://github.com/apache/couchdb-hyper/pull/2#discussion_r191979744
##########
File path: test/hyper_test.erl
##########
@@ -305,11 +302,11 @@ small_big_union_t() ->
BigSet = sets:from_list(generate_unique(BigCard)),
SmallHyper = hyper:insert_many(sets:to_list(SmallSet),
- hyper:new(15, hyper_bisect)),
+ hyper:new(15)),
BigHyper = hyper:insert_many(sets:to_list(BigSet),
- hyper:new(15, hyper_bisect)),
- ?assertMatch({hyper_bisect, {sparse, _, _, _}},
SmallHyper#hyper.registers),
- ?assertMatch({hyper_bisect, {dense, _}}, BigHyper#hyper.registers),
+ hyper:new(15)),
+ %?assertMatch({hyper_bisect, {sparse, _, _, _}},
SmallHyper#hyper.registers),
+ %?assertMatch({hyper_bisect, {dense, _}}, BigHyper#hyper.registers),
Review comment:
I was about to comment the whole test out but had noticed that the binary
also has a dense vs sparse representation so it still seemed like a useful test
for binaries still:
https://github.com/apache/couchdb-hyper/blob/4b1abc4284fc784f6def4f4928f715b0d33136f9/src/hyper_binary.erl#L28
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
