kocolosk commented on issue #1377: Fix _approx_count_distinct on non-clustered 
interface, optimize _stats
URL: https://github.com/apache/couchdb/pull/1377#issuecomment-395278681
 
 
   @wohali not 100% sure what you mean. Travis is running the automated tests 
for both of those and catching where I've missed something. In this case I 
missed the fact that `_statsorama` and `_stats\nare\nawesome` are apparently 
valid ways to invoke the `_stats` reduce function 🙄. Thanks JChris!
   
   If you're saying I ought to run the full test suite locally before opening 
the PR ... yes OK I need to figure out how to do that. I futzed with the 
firewall on my laptop a bit and eventually gave up.
   
   If you're saying we need to test both 5984 and 5986 as part of the test 
suite that's probably worth filing an issue.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to