garrensmith commented on issue #1376: Add fields to sort based on selector URL: https://github.com/apache/couchdb/pull/1376#issuecomment-395425356 thanks @davisp that was a really helpful review. I've done all the code changes you suggested. I've also moved all the `maybe_filter_sort_fields` into the index implementation modules. The implementation you suggested doesn't work for the case where we might have a missing field in the middle of a sort list like [here](https://github.com/apache/couchdb/pull/1376/files#diff-cf1206e8c258c0a911b68eaaf80c8085R157) I've also rewritten the explanation in the code. Hopefully that makes more sense. I've also edited the PR explanation above with the same text.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
