tonysun83 commented on a change in pull request #1376: Add fields to sort based
on selector
URL: https://github.com/apache/couchdb/pull/1376#discussion_r194955326
##########
File path: src/mango/src/mango_idx_view.erl
##########
@@ -511,3 +512,44 @@ range_pos(Low, Arg, High) ->
max
end
end.
+
+
+maybe_filter_by_sort_fields(Idx, SortFields, Selector) ->
+ Cols = mango_idx:columns(Idx),
Review comment:
I noticed this call was moved from ```mango_idx``` into each of three
separate index types. You don't use ref ```Idx``` anywhere else, so perhaps you
could move this line back and just pass in ```Cols``` as in a parameter? Having
said that, in the future it might be useful if we need the entire index record
for other purposes. If that is the case, then we can leave it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
