garrensmith commented on a change in pull request #1376: Add fields to sort
based on selector
URL: https://github.com/apache/couchdb/pull/1376#discussion_r195110392
##########
File path: src/mango/src/mango_idx_view.erl
##########
@@ -511,3 +512,44 @@ range_pos(Low, Arg, High) ->
max
end
end.
+
+
+maybe_filter_by_sort_fields(Idx, SortFields, Selector) ->
+ Cols = mango_idx:columns(Idx),
Review comment:
I was in two minds here. Initially, I only passed in the `Cols` but then I
thought it might be better to support Idx in case we need it for another
reason. I don't really mind. Having Idx might future proof it a little.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
