kocolosk commented on a change in pull request #1370: [5/5] Clustered Purge Implementation URL: https://github.com/apache/couchdb/pull/1370#discussion_r195250327
########## File path: src/couch_index/src/couch_index_updater.erl ########## @@ -208,12 +211,27 @@ update(Idx, Mod, IdxState) -> purge_index(Db, Mod, IdxState) -> {ok, DbPurgeSeq} = couch_db:get_purge_seq(Db), IdxPurgeSeq = Mod:get(purge_seq, IdxState), - if - DbPurgeSeq == IdxPurgeSeq -> - {ok, IdxState}; - DbPurgeSeq == IdxPurgeSeq + 1 -> - {ok, PurgedIdRevs} = couch_db:get_last_purged(Db), - Mod:purge(Db, DbPurgeSeq, PurgedIdRevs, IdxState); - true -> - reset + if IdxPurgeSeq == DbPurgeSeq -> {ok, IdxState}; true -> + FoldFun = fun({PurgeSeq, _UUId, Id, Revs}, Acc) -> + Mod:purge(Db, PurgeSeq, [{Id, Revs}], Acc) + end, Review comment: Yeah, sure, I'm fine either way. I noticed that all the infrastructure seemed to be in place for it, and you were already doing some batching in internal replication (following the pattern that already existed). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services