eiri commented on a change in pull request #1387: Make `bin_opt_info` optional
URL: https://github.com/apache/couchdb/pull/1387#discussion_r195494345
 
 

 ##########
 File path: rebar.config.script
 ##########
 @@ -87,13 +87,18 @@ MakeDep = fun
         {AppName, ".*", {git, Url, Version}, Options}
 end,
 
+ErlOpts = case os:getenv("ERL_OPTS") of
+    "bin_opt_info" -> [bin_opt_info, debug_info, {i, "../"}];
 
 Review comment:
   `debug_info` in clause is a copy-paste error, thanks for pointing.
   
   Passing value of env variable not going to work though, options have to be 
erlang term i.e. `bin_opt_info` need to be an atom, not a string. Also just 
marshalling os env into options is kind of dangerous.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to