wohali commented on issue #1393: Switch away from passing funs between nodes 
when uploading attachments
URL: https://github.com/apache/couchdb/pull/1393#issuecomment-398519283
 
 
   I can't review the code here, but I insist you add something to the 
documentation about this new flag, even if it's just in 
`rel/overlay/etc/default.ini`.
   
   Speaking of which, I don't see any changes in this PR to that file 
:disappointed:  **ALL** new `config:get` entries should be paired with a change 
to `default.ini`.
   
   When we change the default value and remove the config option, we will need 
a big screaming warning in the upgrade docs that says rolling upgrades from 
older CouchDBs that have the value set to `false` will fail. (It might be worth 
describing exactly how those upgrades will fail, too.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to