Antonio-Maranhao commented on a change in pull request #1097: Change how 
credentials are checked for new replication
URL: https://github.com/apache/couchdb-fauxton/pull/1097#discussion_r198144453
 
 

 ##########
 File path: app/addons/replication/components/newreplication.js
 ##########
 @@ -101,6 +99,18 @@ export default class NewReplicationController extends 
React.Component {
     });
   }
 
+  checkCredentials(username, password) {
 
 Review comment:
   @popojargo done. FYI I had to fix `json()` since the `opts` values were not 
overriding the defaults - and they should based on the jsdoc.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to