iilyak commented on a change in pull request #1370: [5/5] Clustered Purge
Implementation
URL: https://github.com/apache/couchdb/pull/1370#discussion_r198435306
##########
File path: src/mem3/src/mem3_rep.erl
##########
@@ -249,8 +248,9 @@ pull_purges(#acc{} = Acc0) ->
end,
if Remaining =< 0 -> ok; true ->
- OldestPurgeSeq = couch_db:get_oldest_purge_seq(Db),
- PurgesToPush = couch_db:get_purge_seq(Db) - OldestPurgeSeq,
+ {ok, PurgeSeq} = couch_db:get_purge_seq(Db),
Review comment:
Did you verify it returns `{ok, pos_integer()}`? Even though dialyzer
complains the tests are written in such a way that `ok` tag is not suppose to
be there
[see](https://github.com/apache/couchdb/blob/master/src/couch/src/test_engine_purge_docs.erl#L32).
So either these tests are not running (which wouldn't surprise me given our
previous experience with eunit) or the tag is added elsewere. Could you show me
the lines where `{ok, integer()}` reply is formed? Also please verify that
tests I pointed to are running.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
