janl edited a comment on issue #1435: report git sha on welcome request URL: https://github.com/apache/couchdb/pull/1435#issuecomment-405025465 I tried a good while trying to get this going, but it is not going to be a trivial patch. The problem is as follows: the git sha is only known at `make dist` time. At that point, `make dist` runs `git archive` to build the tarball. That means that only files that have been committed to the source tree make it into the source archive. In order to get the git sha in there, we’d have to make a commit. Or to ament the tarball with a new file that contains the git sha. The former doesn’t sound right to me as that would make the tarball dependent on a commit that will only exist on the release manager’s machine, plus those commits would never make sense to share. The second option might be worth investigating, but I ran out of time for this. Dropping from 2.2.0 unless someone picks this up.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
