glynnbird opened a new pull request #113: Prevent callback users seeing Promise 
rejections
URL: https://github.com/apache/couchdb-nano/pull/113
 
 
   ## Overview
   
   As pointed out in issue #112, by returning a Promise in most function calls 
in Nano 7 has unintended consequences for callback-only users. If the Promise 
rejects, the library user gets an ugly error.
   
   This PR fixes that.
   
   ## Testing recommendations
   
   ```js
   db.get('missingid', function(err, data) {
     console.log(err)
   });
   ```
   
   The above code should not give a Promise rejection warning.
   
   ## GitHub issue number
   
   Issue #112 
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [x] Documentation reflects the changes;
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to