wohali commented on issue #27: vm.args is now editable -- enabling clusters; 
snap set works for name and cookie 
URL: https://github.com/apache/couchdb-pkg/pull/27#issuecomment-416466046
 
 
   Oops, my mistake, we have our Travis tests over in the apache/couchdb-ci 
repo. We can add one here as well.
   
   Here's a link to the couchdb-ci one: 
https://github.com/apache/couchdb-ci/blob/master/.travis.yml
   
   And our Docker one, which actually starts up a CouchDB docker container, 
waits 10 seconds, then checks to make sure it's correctly up and running: 
https://github.com/apache/couchdb-docker/blob/master/.travis.yml
   
   As you can see we're running inside of a Docker container on specific 
platforms, and then running the `./build.sh` command inside of each that kicks 
off a JS or Couch packaging run. This repo hasn't been Travis enabled yet, so 
there's no similar file here.
   
   It's probably best to add a PR to that repo to update the Travis file to try 
building the snap on e.g. ubuntu-bionic only, and see if it works. You could 
add a 3rd script command that simply tests if it's on the right version of 
Ubuntu, and does the snap build & test if it is.
   
   If you're good with that, I'll merge this PR (but reserve the right to 
revert the README file change if we can't get CI tests working correctly, ok?) 
Then please open a PR over on couchdb-ci when you're ready to add snap package 
testing there.
   
   Thank you so much for your soon-to-be-merged contribution to CouchDB! :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to