kocolosk opened a new pull request #110: Conditionally set ownership and 
permissions in entrypoint
URL: https://github.com/apache/couchdb-docker/pull/110
 
 
   ## Overview
   
   Three significant changes here:
   
   1. Check ownership/permissions and only execute chown/chmod when necessary
   1. Switch target permissions to those set by CouchDB itself
   1. Drop the `-f` flag and the silent `|| true` guard on these commands
   
   The last one is perhaps worth discussion. I couldn't find any explanation 
for why it was added in the first place, and I didn't see it being used on 
comparable docker-entrypoint files in other projects. I figured that if we feel 
these commands are important enough to place in the entry point we probably 
don't want them to be silently ignored.
   
   ## GitHub issue number
   
   Fixes #109 
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [ ] Changes are covered by tests;
   - [x] Documentation reflects the changes;
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to