janl commented on a change in pull request #1602: Remove runtime
configurability of core system components
URL: https://github.com/apache/couchdb/pull/1602#discussion_r232193171
##########
File path: src/couch/src/couch_secondary_sup.erl
##########
@@ -26,6 +26,16 @@ init([]) ->
worker,
dynamic}
],
+ Daemons = [
+ {"index_server", "{couch_index_server, start_link, []}"},
Review comment:
Latest push removes the redundant string parsing. I’d accept commits that
turn the list comprehension into a helper, or one that writes it all out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services