jaydoane commented on a change in pull request #1722: Retain replication stats between job runs URL: https://github.com/apache/couchdb/pull/1722#discussion_r232361229
########## File path: src/couch_replicator/src/couch_replicator_scheduler_job.erl ########## @@ -159,16 +159,9 @@ do_init(#rep{options = Options, id = {BaseId, Ext}, user_ctx=UserCtx} = Rep) -> {source, ?l2b(SourceName)}, {target, ?l2b(TargetName)}, {continuous, get_value(continuous, Options, false)}, - {revisions_checked, 0}, - {missing_revisions_found, 0}, - {docs_read, 0}, - {docs_written, 0}, - {changes_pending, get_pending_count(State)}, - {doc_write_failures, 0}, {source_seq, HighestSeq}, - {checkpointed_source_seq, CommittedSeq}, {checkpoint_interval, CheckpointInterval} - ]), + ] ++ rep_stats(State)), Review comment: It seems like this refactor introduced a new warning: ``` db/src/couchdb/src/couch_replicator/src/couch_replicator_scheduler_job.erl:121: Warning: variable 'CommittedSeq' is unused ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services