flimzy commented on a change in pull request #328: feat: update docs for new query server config URL: https://github.com/apache/couchdb-documentation/pull/328#discussion_r232485835
########## File path: src/config/query-servers.rst ########## @@ -23,28 +23,28 @@ Query Servers Definition .. config:section:: query_servers :: Query Servers Definition - .. versionchanged:: 1.2: Added CoffeeScript query server + .. versionchanged:: 2.3: Changed configuration method for Query Servers + and Native Query Servers. CouchDB delegates computation of :ref:`design documents <ddocs>` functions to external query servers. The external query server is a special OS process which communicates with CouchDB over standard input/output using a very simple line-based protocol with JSON messages. - The external query server may be defined in configuration file following + The external query server may be defined with environment variables following next pattern:: - [query_servers] - LANGUAGE = PATH ARGS + COUCHDB_QUERY_SERVER_LANGUAGE="PATH ARGS" Where: - ``LANGUAGE``: is a programming language which code this query server may execute. For instance, there are `python`, `ruby`, `clojure` and other - query servers in wild. This value is also used for `ddoc` field - ``language`` to determine which query server processes the functions. + query servers in wild. This value in lowercase is also used for `ddoc` + field ``language`` to determine which query server processes the functions. Note, that you may set up multiple query servers for the same programming - language, but you have to name them different (like `python-dev` etc.). + language, but you have to name them different (like `PYTHONDEV` etc.). Review comment: I know you didn't change this, but "different" should be "differently", and "like" seems very informal, IMO. ```suggestion language, but you have to name them differently (i.e. `PYTHON` and `PYTHONDEV`). ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services