wohali commented on a change in pull request #1639: Switch to python 3
URL: https://github.com/apache/couchdb/pull/1639#discussion_r233967095
##########
File path: src/mango/Makefile
##########
@@ -39,7 +39,7 @@ help:
.PHONY: test
# target: test - Runs test suite
test:
- nosetests
+ ./venv/bin/nosetests
Review comment:
I thought we agreed we wouldn't use a virtualenv for this.
Besides, you haven't even `pip install`ed the prerequisites necessary into
that venv.
Finally, the top level `Makefile` is unchanged in this PR, meaning when you
do a `make check` or `make mango-test` you execute:
```makefile
.PHONY: mango-test
# target: mango-test - Run Mango tests
mango-test: devclean all
@cd src/mango && ../../dev/run -n 1 --admin=testuser:testpass nosetests
```
Would like to see consistency here, one way or the other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
