iilyak commented on a change in pull request #1747: Set query server env variable in Makefile for isolated eunit tests URL: https://github.com/apache/couchdb/pull/1747#discussion_r234751186
########## File path: Makefile ########## @@ -148,6 +148,7 @@ check: all # target: eunit - Run EUnit tests, use EUNIT_OPTS to provide custom options eunit: export BUILDDIR = $(shell pwd) eunit: export ERL_AFLAGS = -config $(shell pwd)/rel/files/eunit.config +eunit: export COUCHDB_QUERY_SERVER_JAVASCRIPT = $(shell pwd)/bin/couchjs $(shell pwd)/share/server/main.js Review comment: > but it's inconsistent with usage pwd everywhere else and feels kind of flimsy, setting env var in one step then depending on it in another. I looked only at a diff and missed the fact that is used everywhere. It looked strange to see `export BUILDIR` and `$(shell pwd)` two lines bellow. > Why do you want this change? It is just a suggestion I am fine with the way you wrote it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
