eiri commented on a change in pull request #1747: Set query server env variable
in Makefile for isolated eunit tests
URL: https://github.com/apache/couchdb/pull/1747#discussion_r234764864
##########
File path: Makefile
##########
@@ -148,6 +148,7 @@ check: all
# target: eunit - Run EUnit tests, use EUNIT_OPTS to provide custom options
eunit: export BUILDDIR = $(shell pwd)
eunit: export ERL_AFLAGS = -config $(shell pwd)/rel/files/eunit.config
+eunit: export COUCHDB_QUERY_SERVER_JAVASCRIPT = $(shell pwd)/bin/couchjs
$(shell pwd)/share/server/main.js
Review comment:
> It looked strange to see export BUILDIR and $(shell pwd) two lines bellow.
and one line above too 😄
Well, I agree it's not the best way to write Makefiles and better way to go
about it would be something like `ROOTDIR := $(shell pwd)` to expand current
dir at top of `Makefile` and then just use make's var `${ROOTDIR}` everywhere
else. But this is a bit bigger change for a quick fix I intended to do, so
since you don't have strong feelings about it I'll go ahead with how it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
