jaydoane opened a new pull request #1798: Suppress compiler warnings URL: https://github.com/apache/couchdb/pull/1798 <!-- Thank you for your contribution! Please file this form by replacing the Markdown comments with your text. If a section needs no action - remove it. Also remember, that CouchDB uses the Review-Then-Commit (RTC) model of code collaboration. Positive feedback is represented +1 from committers and negative is a -1. The -1 also means veto, and needs to be addressed to proceed. Once there are no objections, the PR can be merged by a CouchDB committer. See: http://couchdb.apache.org/bylaws.html#decisions for more info. --> ## Overview Suppress warnings when compiled with OTP 20.3 <!-- Please give a short brief for the pull request, what problem it solves or how it makes things better. --> ## Testing recommendations After applying these changes, `make clean && make` using OTP 20 should have many fewer compiler warnings than before. Of course, numerous dependencies still emit compiler warnings. <!-- Describe how we can test your changes. Does it provides any behaviour that the end users could notice? --> ## Persistent behaviour warnings I'm still seeing the following behaviour warnings ``` couchdb/src/couch/src/couch_bt_engine.erl:14: Warning: behaviour couch_db_engine undefined couchdb/src/couch_replicator/src/couch_replicator_clustering.erl:31: Warning: behaviour mem3_cluster undefined couchdb/src/couch_peruser/src/couch_peruser.erl:15: Warning: behaviour mem3_cluster undefined ``` but it's not obvious why. The dependent applications are included in .app.src files, and it appears that the callbacks are implemented correctly. Any help figuring these out would be appreciated. ## Related Issues or Pull Requests <!-- If your changes affects multiple components in different repositories please put links to those issues or pull requests here. --> ## Checklist - [x] Code is written and works correctly; - [x] Changes are covered by tests; - [ ] Documentation reflects the changes;
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
