jiangphcn commented on a change in pull request #1798: Suppress compiler 
warnings
URL: https://github.com/apache/couchdb/pull/1798#discussion_r239714326
 
 

 ##########
 File path: src/couch_pse_tests/src/cpse_test_fold_changes.erl
 ##########
 @@ -170,25 +171,11 @@ do_mutation_ordering(Db, Seq, [{DocId, _OldSeq} | Rest], 
DocSeqAcc) ->
 
 
 shuffle(List) ->
-    random:seed(os:timestamp()),
-    Paired = [{random:uniform(), I} || I <- List],
+    Paired = [{couch_random:uniform(), I} || I <- List],
 
 Review comment:
   we can find below from https://travis-ci.org/apache/couchdb/jobs/464727536. 
Try `make eunit` from root directory. But I guess that there is easy way to 
only run test cases from  `couch_pse_tests`. cc @davisp 
   ```
   [os_mon] cpu supervisor port (cpu_sup): Erlang has closed
         [done in 0.453 s]
       cpse_test_fold_changes
         cpse_gather: make_test_fun (cpse_empty_changes)...ok
         cpse_gather: make_test_fun (cpse_single_change)...[0.010 s] ok
         cpse_gather: make_test_fun (cpse_two_changes)...[0.025 s] ok
         cpse_gather: make_test_fun (cpse_two_changes_batch)...[0.010 s] ok
         cpse_gather: make_test_fun (cpse_two_changes_batch_sorted)...[0.010 s] 
ok
         cpse_gather: make_test_fun (cpse_update_one)...[0.025 s] ok
         cpse_gather: make_test_fun (cpse_update_first_of_two)...[0.044 s] ok
         cpse_gather: make_test_fun (cpse_update_second_of_two)...[0.033 s] ok
         cpse_gather: make_test_fun (cpse_check_mutation_ordering)...[0.643 s] 
ok
   ```
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to