nickva commented on issue #1798: Suppress compiler warnings
URL: https://github.com/apache/couchdb/pull/1798#issuecomment-445332896
 
 
   @jaydoane 
   
   Thanks for checking. We'd basically want mem3 compiled before say 
couch_peruser. I tried removing module from mem3 and moving it before couch and 
couch_peruser app in rebar config file. That cleared those 3 behavior warning. 
However because of the circular dependency between mem3 and couch another one 
popup up as expected:
   
   ```
   src/mem3/src/mem3_sync_event_listener.erl:14: Warning: behaviour 
couch_event_listener undefined
   ```
   
   ```
   diff --git a/rebar.config.script b/rebar.config.script
   index 5f17c29e0..598097459 100644
   --- a/rebar.config.script
   +++ b/rebar.config.script
   @@ -26,6 +26,7 @@ SubDirs = [
        "src/couch_epi",
        "src/couch_log",
        "src/chttpd",
   +    "src/mem3",
        "src/couch",
        "src/couch_index",
        "src/couch_mrview",
   @@ -40,7 +41,6 @@ SubDirs = [
        "src/fabric",
        "src/global_changes",
        "src/mango",
   -    "src/mem3",
        "src/rexi",
        "src/setup",
        "rel"
   diff --git a/src/mem3/src/mem3.app.src b/src/mem3/src/mem3.app.src
   index 99a9eed88..15efc64ca 100644
   --- a/src/mem3/src/mem3.app.src
   +++ b/src/mem3/src/mem3.app.src
   @@ -13,20 +13,6 @@
    {application, mem3, [
        {description, "CouchDB Cluster Membership"},
        {vsn, git},
   -    {modules, [
   -        mem3,
   -        mem3_app,
   -        mem3_httpd,
   -        mem3_nodes,
   -        mem3_rep,
   -        mem3_shards,
   -        mem3_sup,
   -        mem3_sync,
   -        mem3_sync_event,
   -        mem3_sync_nodes,
   -        mem3_sync_security,
   -        mem3_util
   -    ]},
        {mod, {mem3_app, []}},
        {registered, [
            mem3_events,
   ```
   
   so we trade 3 warning for 1. Still a bit better!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to