wohali commented on a change in pull request #40: Detect Arch Support
URL: https://github.com/apache/couchdb-pkg/pull/40#discussion_r240679644
##########
File path: Makefile
##########
@@ -154,10 +154,12 @@ build-rpm:
# ######################################
copy-pkgs:
- -chmod a+rwx ../rpmbuild/RPMS/x86_64/couchdb-* ../couchdb/couchdb_*
2>/dev/null
- -mkdir -p pkgs/couch/$(DIST) && chmod 777 pkgs/couch/$(DIST)
- -cp ../rpmbuild/RPMS/x86_64/couchdb-* pkgs/couch/$(DIST) 2>/dev/null
- -cp ../couchdb/couchdb_* pkgs/couch/$(DIST) 2>/dev/null
+ if [ "$(shell arch)" = "x84_64" ]; then
\
Review comment:
Just to clarify - the package builds run in a container that will
*definitely* have a different uid, but since they are building the package,
they are the ones that build the files under the two directories being
`chmod`ed. One of the two won't be found (since we are only on one path) but
the other *should* succeed in its chmod and the chmod is *mandatory* otherwise
we won't be able to modify/move the file outside of the container.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
