davisp commented on a change in pull request #1789: New Feature: Database
Partitions
URL: https://github.com/apache/couchdb/pull/1789#discussion_r242690396
##########
File path: test/elixir/test/partition_design_docs_test.exs
##########
@@ -0,0 +1,16 @@
+defmodule PartitionDesignDocsTest do
+ use CouchTestCase
+
+ @moduledoc """
+ Test Partition functionality for partition design docs
+ """
+
+ @tag :with_partitioned_db
+ test "/_partition/:pk/_design/doc 404", context do
+ db_name = context[:db_name]
+
+ url = "/#{db_name}/_partition/fake-key/_design/mrtest/"
+ resp = Couch.get(url)
+ assert resp.status_code == 404
Review comment:
Hrm. Mebbe. Its just showing that we can't hit that route via the _partition
endpoint. Also I tend to not assert on human readable text as that gets brittle
if things are revised for clarity. I'd be happy to add the error value
assertion I guess but if 404 wasn't `"error":"not_found"` we've got much bigger
problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
