davisp commented on issue #2015: parse_revid - Badarg error in HTTP request URL: https://github.com/apache/couchdb/issues/2015#issuecomment-487596929 I haven't got any issue adding a fallback that just reuses the provided rev even if its doesn't parse as hex. I'd agree that its basically just space savings for both RAM and disk usage. The only issue I have with people creating "meaningful" revisions is that there's always the possibility that we evolve our own "differently meaningful" revisions in the future which may end up being incompatible. However, given that we're currently not versioning them that's also on us to be thoughtful of if we were to ever do that (not that I've ever heard of any ideas around doing that, just noting the possibility exists). Also, fun fact but we also have weirdness in the opposite direction. If someone were to create a custom revision that is 16 bytes long, it'll get hex-ified [1] on the way out which is also something to think about. [1] https://github.com/apache/couchdb/blob/master/src/couch/src/couch_doc.erl#L70
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
