kocolosk commented on issue #2037: Add "Dreyfus" (Erlang side of Search) to CouchDB URL: https://github.com/apache/couchdb/pull/2037#issuecomment-502258830 @nowisesys pointed out an interesting issue with this Pull Request. We have an ancient pattern in Mango which does a `module_loaded(dreyfus_index)` to check for the presence of Dreyfus before advertising text indexes. In release mode that module is not loaded on startup, so even if Dreyfus is included in a release the check can fail. Oops! A trivial switch here would be to use `dreyfus_sup` instead of `dreyfus_index` as the former will be loaded as part of the supervision tree, but that doesn't actually confirm a working Search system since this PR proposes to always start the Dreyfus app. I think we should come up with a smarter approach -- perhaps testing for a connected Clouseau node instead? /cc @rnewson @tonysun83 for comment
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
