nickva commented on issue #2126: Update httpotion to 3.1.3
URL: https://github.com/apache/couchdb/pull/2126#issuecomment-522628032
 
 
   Are we still setting the proper httpotion/ibrowse timeouts, where does that 
happen:
   
   ```
       timeout =
         Keyword.get(
           options,
           :timeout,
           Application.get_env(:httpotion, :default_timeout, @request_timeout)
         )
   
       ib_options =
         Keyword.merge(
           Application.get_env(:httpotion, :default_ibrowse, []),
           Keyword.get(options, :ibrowse, [{:inactivity_timeout, 
@inactivity_timeout}])
         )
   ```
   
   I had also noticed new unused tags warnings:
   
   ```
   warning: module attribute @inactivity_timeout was set but never used
     test/elixir/lib/couch.ex:59
   warning: module attribute @request_timeout was set but never used
     test/elixir/lib/couch.ex:58
   ```
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to