willholley opened a new pull request #2346: Big-endian support for couch_compress tests URL: https://github.com/apache/couchdb/pull/2346 <!-- Thank you for your contribution! Please file this form by replacing the Markdown comments with your text. If a section needs no action - remove it. Also remember, that CouchDB uses the Review-Then-Commit (RTC) model of code collaboration. Positive feedback is represented +1 from committers and negative is a -1. The -1 also means veto, and needs to be addressed to proceed. Once there are no objections, the PR can be merged by a CouchDB committer. See: http://couchdb.apache.org/bylaws.html#decisions for more info. --> ## Overview This refactors the couch_compress tests to allow them to run on platforms (e.g. s390x) where the compression output might be different to the fixed values defined in the tests. Namely: * Assert that compressed output is smaller than the input * Assert bigendian output is portable * Assert that compressed output can be re-compressed The first commit in the PR is a straight port of the existing couch_compress test fixture to ExUnit. The second commit makes the modifications described above. cc @davisp ## Testing recommendations <!-- Describe how we can test your changes. Does it provides any behaviour that the end users could notice? --> ``` make tests=src/couch/test/exunit/couch_compress_tests.exs exunit ``` ## Related Issues or Pull Requests Background and discussion of this is in https://issues.apache.org/jira/browse/COUCHDB-3261. ## Checklist - [ ] Code is written and works correctly - [ ] Changes are covered by tests - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini` - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
