garrensmith commented on a change in pull request #2410: Mango metrics
URL: https://github.com/apache/couchdb/pull/2410#discussion_r364261490
##########
File path: src/mango/src/mango_execution_stats.erl
##########
@@ -82,9 +83,11 @@ log_end(Stats) ->
maybe_add_stats(Opts, UserFun, Stats, UserAcc) ->
+ Stats0 = log_end(Stats),
Review comment:
A variable with a 0 is lower that Stats. So you could make the first
variable of Stats as Stats0 eg:
```
maybe_add_stats(Opts, UserFun, Stats0, UserAcc) ->
Stats = log_end(Stats0),
```
Is how its typically done in the CouchDB codebase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
