mhamann opened a new pull request #1246: Nav: Fix potential ID selector 
collisions
URL: https://github.com/apache/couchdb-fauxton/pull/1246
 
 
   ## Overview
   
   If a design doc is created with a name that conflicts with an existing HTML 
element's ID, it will receive the styling for that element in addition to 
causing invalid HTML.
   
   In my case, I'd created a design doc named `dashboard`, which then produced 
a navigation item with an ID of `#dashboard`. This conflicts with the existing 
`#dashboard` element, which has several CSS styles applied. It then breaks the 
navigation layout (see screenshot). It becomes impossible to edit the views 
within the design doc without manually editing the UI.
   
   
![image](https://user-images.githubusercontent.com/130131/72366271-ed8c2d00-36c7-11ea-8285-477eb08e5aba.png)
   
   This change prefixes those IDs in order to ensure they
   are unique.
   
   
   ## Testing recommendations
   
   Tested the UI locally to ensure the rendering was fixed and that I could 
still access my docs, views, etc.
   
   
![image](https://user-images.githubusercontent.com/130131/72366321-04328400-36c8-11ea-9d7d-cb6b17c17ad1.png)
   
   
   ## GitHub issue number
   
   N/A
   
   ## Related Pull Requests
   
   N/A
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [ ] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   - [ ] Update 
[rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script)
 with the correct tag once a new Fauxton release is made
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to